-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update registry operator deployment specs to match changes on the registry server and registry viewer #28
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…wer image getter added to defaults.go Signed-off-by: Michael Valdron <mvaldron@redhat.com>
… and remove elements of the old registry viewer. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…pec descriptions fixed. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Skipping CI for Draft Pull Request. |
Codecov ReportBase: 24.28% // Head: 23.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 24.28% 23.16% -1.13%
==========================================
Files 22 22
Lines 1054 1105 +51
==========================================
Hits 256 256
- Misses 789 840 +51
Partials 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- env var indexing updated for index container - detects when registry viewer image is updated Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…nabled. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…tion'. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
530f647
to
d77a6c5
Compare
testing blocked by PR devfile/registry#149 |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…able value type changed to use boolean values. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
registry server
registry viewer
What does does this PR do / why we need it:
With the updates done the registry server build and deployment process along with the new and separated registry viewer, additional changes are needed to how the registry operator deploys the devfile registry to Kubernetes and OpenShift. These changes are as follows:
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#747
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: