Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry operator deployment specs to match changes on the registry server and registry viewer #28

Merged
merged 15 commits into from
Jan 12, 2023

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Nov 10, 2022

Please specify the area for this PR
registry server
registry viewer

What does does this PR do / why we need it:

With the updates done the registry server build and deployment process along with the new and separated registry viewer, additional changes are needed to how the registry operator deploys the devfile registry to Kubernetes and OpenShift. These changes are as follows:

  • Support for headless deployment of the registry server
  • Separate container deployment of the registry viewer (when headless mode is disabled)
  • Removal of the startup probe on the registry server container to test if registry viewer is locally running

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#747

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…wer image getter added to defaults.go

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
… and remove elements of the old registry viewer.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…pec descriptions fixed.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 24.28% // Head: 23.16% // Decreases project coverage by -1.12% ⚠️

Coverage data is based on head (9e36862) compared to base (07d69b2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   24.28%   23.16%   -1.13%     
==========================================
  Files          22       22              
  Lines        1054     1105      +51     
==========================================
  Hits          256      256              
- Misses        789      840      +51     
  Partials        9        9              
Impacted Files Coverage Δ
api/v1alpha1/devfileregistry_types.go 100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go 26.22% <0.00%> (-0.60%) ⬇️
controllers/update.go 0.00% <0.00%> (ø)
pkg/registry/configmap.go 0.00% <0.00%> (ø)
pkg/registry/defaults.go 59.18% <0.00%> (-15.18%) ⬇️
pkg/registry/deployment.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

- env var indexing updated for index container
- detects when registry viewer image is updated

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…nabled.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…tion'.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

michael-valdron commented Nov 15, 2022

testing blocked by PR devfile/registry#149

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…able value type changed to use boolean values.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 16, 2022

@michael-valdron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.11-registry-operator-integration-test d77a6c5 link true /test v4.11-registry-operator-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michael-valdron michael-valdron marked this pull request as ready for review December 20, 2022 18:50
@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 71b9284 into devfile:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants