Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gosec v2.14.0 to prevent breakage #34

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

michael-valdron
Copy link
Member

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR

CI

What does does this PR do / why we need it:

Applies latest version which does not require golang 1.19, so that this CI check does not break during module install.

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#1021

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Feb 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 21.32% // Head: 21.32% // No change to project coverage 👍

Coverage data is based on head (6a38269) compared to base (d6da16a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files          22       22           
  Lines        1163     1163           
=======================================
  Hits          248      248           
+ Misses        905      904    -1     
- Partials       10       11    +1     
Impacted Files Coverage Δ
...rollers/clusterdevfileregistrieslist_controller.go 78.57% <0.00%> (-14.29%) ⬇️
controllers/devfileregistrieslist_controller.go 78.57% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-valdron michael-valdron merged commit eecf84e into devfile:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants