Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry fix for registry operator deployment #35

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Feb 14, 2023

Please specify the area for this PR

operator

What does does this PR do / why we need it:

Corrects the environment variable name for the analytics write key, ANALYTICS_WRITE_KEY to NEXT_PUBLIC_ANALYTICS_WRITE_KEY. This change should fix the broken telemetry.

Additionally these changes include the missing environment variable spec definitions which should of been part of devfile/api#1016.

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#1006

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
pkg/registry/deployment.go Outdated Show resolved Hide resolved
pkg/registry/deployment.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 21.32% // Head: 21.35% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (bc4db8d) compared to base (d6da16a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   21.32%   21.35%   +0.03%     
==========================================
  Files          22       22              
  Lines        1163     1180      +17     
==========================================
+ Hits          248      252       +4     
- Misses        905      918      +13     
  Partials       10       10              
Impacted Files Coverage Δ
pkg/registry/configmap.go 0.00% <0.00%> (ø)
pkg/registry/deployment.go 0.00% <0.00%> (ø)
...rollers/clusterdevfileregistrieslist_controller.go 78.57% <0.00%> (-14.29%) ⬇️
controllers/devfileregistrieslist_controller.go 92.85% <0.00%> (+28.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ewer config

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 3665c9b into devfile:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants