Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness and readiness probes to registry viewer container in the registry operator #36

Merged
merged 5 commits into from
Mar 27, 2023

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Feb 27, 2023

Please specify the area for this PR

What does does this PR do / why we need it:

Adds missing required probes removed in devfile/api#1019.

Other fixes:

  • Configmap mount to registry viewer envfile set to read only
  • URI Scheme for probes set to HTTP
  • Insecure edge termination policy is set to redirect

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#1040

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.60 ⚠️

Comparison is base (3665c9b) 21.69% compared to head (6d90889) 21.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   21.69%   21.10%   -0.60%     
==========================================
  Files          22       22              
  Lines        1180     1213      +33     
==========================================
  Hits          256      256              
- Misses        915      948      +33     
  Partials        9        9              
Impacted Files Coverage Δ
pkg/registry/deployment.go 0.00% <0.00%> (ø)
pkg/registry/route.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review March 21, 2023 18:09
@michael-valdron michael-valdron changed the title [WIP]Add liveness and readiness probes to registry viewer container in the registry operator Add liveness and readiness probes to registry viewer container in the registry operator Mar 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 09342cf into devfile:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants