Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container spec with image tag and image pull policy fields #38

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

registry

What does does this PR do / why we need it:

Adds a new container spec which now defines the fields to setup the individual containers in the deployed pod. This new spec currently supports image and imagePullPolicy (requested in devfile/api#730) with the scalability to add new container fields in the near future (e.g. memoryLimit).

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#730

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@github-advanced-security
Copy link

You have successfully added a new gosec configuration .github/workflows/ci.yaml:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the bundle manifest to make sure everything is in sync, otherwise everything else looks good

@openshift-ci
Copy link

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Mar 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

New changes are detected. LGTM label has been removed.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.48 ⚠️

Comparison is base (4ba7375) 21.35% compared to head (9b37b4b) 19.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   21.35%   19.87%   -1.48%     
==========================================
  Files          22       22              
  Lines        1199     1248      +49     
==========================================
- Hits          256      248       -8     
- Misses        934      989      +55     
- Partials        9       11       +2     
Impacted Files Coverage Δ
api/v1alpha1/devfileregistry_types.go 100.00% <ø> (ø)
api/v1alpha1/zz_generated.deepcopy.go 24.89% <0.00%> (-1.33%) ⬇️
controllers/update.go 0.00% <0.00%> (ø)
pkg/registry/defaults.go 41.42% <0.00%> (-17.76%) ⬇️
pkg/registry/deployment.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

/retest

@michael-valdron michael-valdron merged commit dcf2c78 into devfile:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants