-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container spec with image tag and image pull policy fields #38
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
You have successfully added a new gosec configuration |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the bundle manifest to make sure everything is in sync, otherwise everything else looks good
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 21.35% 19.87% -1.48%
==========================================
Files 22 22
Lines 1199 1248 +49
==========================================
- Hits 256 248 -8
- Misses 934 989 +55
- Partials 9 11 +2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
600f934
to
9b37b4b
Compare
/retest |
Please specify the area for this PR
registry
What does does this PR do / why we need it:
Adds a new container spec which now defines the fields to setup the individual containers in the deployed pod. This new spec currently supports
image
andimagePullPolicy
(requested in devfile/api#730) with the scalability to add new container fields in the near future (e.g.memoryLimit
).Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#730
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: