Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot updates #39

Merged
merged 1 commit into from
Apr 4, 2023
Merged

dependabot updates #39

merged 1 commit into from
Apr 4, 2023

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Apr 3, 2023

Please specify the area for this PR

What does does this PR do / why we need it:

  • Picks up the latest registry generator and registry library version
  • removes the dependency on sigs.k8s.io/controller-runtime/pkg/envtest/printer which no longer exists in controller-runtime v0.14.5. Confirmed that removal does not affect formatting of the tests

Which issue(s) this PR fixes:

devfile/api#1081

Fixes #?

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@github-advanced-security
Copy link

You have successfully added a new gosec configuration .github/workflows/ci.yaml:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.52 ⚠️

Comparison is base (dcf2c78) 19.87% compared to head (221b3a2) 19.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   19.87%   19.35%   -0.52%     
==========================================
  Files          22       22              
  Lines        1248     1281      +33     
==========================================
  Hits          248      248              
- Misses        989     1022      +33     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/registry/deployment.go 0.00% <0.00%> (ø)
pkg/registry/route.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit e29b302 into devfile:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants