Storage enabled volume defaults to false

[michael-valdron]

Please specify the area for this PR

registry operator

What does does this PR do / why we need it:

Storage enabled volume property now defaults to false, OCI registry volume now uses emptydir by default. This change fixes permission issues for kubernetes deployments and is work towards proper OCP 4.12 support.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1029
part of devfile/api#1092

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to updated with your changes?

How to test changes / Special notes to the reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[github-advanced-security]

You have successfully added a new gosec configuration .github/workflows/ci.yaml:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (dcf2c78) 19.87% compared to head (a431e76) 19.98%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   19.87%   19.98%   +0.11%     
==========================================
  Files          22       22              
  Lines        1248     1281      +33     
==========================================
+ Hits          248      256       +8     
- Misses        989     1016      +27     
+ Partials       11        9       -2     

Impacted Files	Coverage Δ
api/v1alpha1/devfileregistry_types.go	100.00% <ø> (ø)
pkg/registry/defaults.go	41.42% <ø> (ø)
pkg/registry/deployment.go	0.00% <0.00%> (ø)
pkg/registry/route.go	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.