Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS file #43

Merged
merged 1 commit into from
May 11, 2023
Merged

Add OWNERS file #43

merged 1 commit into from
May 11, 2023

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented May 3, 2023

Please specify the area for this PR

What does does this PR do / why we need it:
Adds the entire devfile team as approvers and reviewers of the integration tests in this repo.

Which issue(s) this PR fixes:

Fixes #?
devfile/api#1027

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michael-valdron
Copy link
Member

Also fixes devfile/api#1105

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d69e00a) 22.72% compared to head (5e9906e) 22.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   22.72%   22.72%           
=======================================
  Files          23       23           
  Lines        1307     1307           
=======================================
  Hits          297      297           
  Misses        995      995           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit ac7373a into devfile:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants