Updates for operator sdk v1.28

[michael-valdron]

Please specify the area for this PR

What does does this PR do / why we need it:

Provides updates to the project files to support Operator SDK version 1.28, these changes are documented under https://sdk.operatorframework.io/docs/upgrading-sdk-version/ up to v1.28 docs.

Additional Changes:

• OpenShift Integration test script deploys 15 seconds before running test suite
• Integration test suite uses registry-operator-system for registry operator pod instead of TEST_NAMESPACE
  • This fixes the ability to use TEST_NAMESPACE as an optional separate namespace for the devfile registry test deployments

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#881
fixes devfile/api#1106

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to updated with your changes?

How to test changes / Special notes to the reviewer:

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.30% 🎉

Comparison is base (9ac9961) 22.41% compared to head (ff9e578) 22.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   22.41%   22.72%   +0.30%     
==========================================
  Files          23       23              
  Lines        1307     1307              
==========================================
+ Hits          293      297       +4     
+ Misses        998      995       -3     
+ Partials       16       15       -1     

Files Changed	Coverage Δ
api/v1alpha1/zz_generated.deepcopy.go	36.28% <ø> (ø)
...rollers/clusterdevfileregistrieslist_controller.go	92.85% <ø> (ø)
controllers/devfileregistrieslist_controller.go	92.85% <ø> (+14.28%)	⬆️
controllers/validate.go	100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johnmcollier]

Left some comments.

Also, could we move back the controller go sources from internal/controller/xyz to just controllers/? I think internal/controller is the default for new controller runtime projects, but the added "internal" in the path is unnecessary for our use case IMO

[michael-valdron]

@michael-valdron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/v4.12-registry-operator-integration-test 1f0abf2 link true /test v4.12-registry-operator-integration-test

Full PR test history. Your PR dashboard.

CI is still running the integration tests using go 1.18, this needs to be updated to go 1.19 for this to pass.

go: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18

[michael-valdron]

Left some comments.

Also, could we move back the controller go sources from internal/controller/xyz to just controllers/? I think internal/controller is the default for new controller runtime projects, but the added "internal" in the path is unnecessary for our use case IMO

Reverted go v4 project structure changes.

[michael-valdron]

/retest

[michael-valdron]

/retest-required

[michael-valdron]

/retest-required

[michael-valdron]

/retest-required

[michael-valdron]

/retest

[michael-valdron]

/test

[openshift-ci]

@michael-valdron: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test v4.12-images
• /test v4.12-registry-operator-integration-test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[michael-valdron]

/test all

[michael-valdron]

/retest

[michael-valdron]

/retest

[johnmcollier]

/retest

[michael-valdron]

/retest

[johnmcollier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnmcollier,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment