-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update owners file #48
Conversation
Signed-off-by: Stephanie <yangcao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 22.11% 22.41% +0.30%
==========================================
Files 23 23
Lines 1307 1307
==========================================
+ Hits 289 293 +4
+ Misses 1002 998 -4
Partials 16 16 ☔ View full report in Codecov by Sentry. |
I've removed the approval as the list of owners is still under consideration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed for all others repos of devfile organization we have:
- elsony
- michael-valdron
- thepetk
- feloy
- rm3l
Signed-off-by: Stephanie <yangcao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thepetk, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
What does does this PR do / why we need it:
This PR updates the owners file
Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: