-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and use oc / kubectl for integration tests #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, could you update this line in the README.md
file accordingly?
https://github.com/feloy/registry-operator/blob/feature-1239/test-with-kubectl/README.md?plain=1#L99
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
aea0872
to
cd1ccac
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 25.86% 25.86%
=======================================
Files 25 25
Lines 1415 1415
=======================================
Hits 366 366
Misses 1026 1026
Partials 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you just update this line in the README.md
file accordingly (especially to mention the use of the env var)?
https://github.com/feloy/registry-operator/blob/feature-1239/test-with-kubectl/README.md?plain=1#L99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fixing the DCO checks and it should be good.
d2cb83a
to
1f1015b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Detect and use oc / kubectl for integration tests Signed-off-by: Philippe Martin <phmartin@redhat.com> * Use K8S_CLI first, then look in path instead of running version command Signed-off-by: Philippe Martin <phmartin@redhat.com> * Document Signed-off-by: Philippe Martin <phmartin@redhat.com> --------- Signed-off-by: Philippe Martin <phmartin@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
What does does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes devfile/api#1239
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: