Release branching workflow revisions #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…parameter Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…s VERSION file instead of ref_name Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
N/A |
michael-valdron
requested review from
rm3l,
kim-tsao and
johnmcollier
and removed request for
elsony and
feloy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 26.43% 26.43%
=======================================
Files 25 25
Lines 1415 1415
=======================================
Hits 374 374
Misses 1020 1020
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thepetk
pushed a commit
to thepetk/devfile-registry-operator
that referenced
this pull request
Aug 20, 2024
* release branching PR workflow Signed-off-by: Michael Valdron <mvaldron@redhat.com> * check version uses VERSION file as base, no longer takes ref_name as parameter Signed-off-by: Michael Valdron <mvaldron@redhat.com> * registry operator built image for release integration testing now uses VERSION file instead of ref_name Signed-off-by: Michael Valdron <mvaldron@redhat.com> * revert docker/build-push-action to v1.1.x Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
These changes are part of revisions to #56 changes to merge release changes to a release branch before creating the release: devfile/api#1267 (comment)
In addition, one of these changes reverts
docker/build-push-actiontov1.1.2the latestv1.1.xversion which fixes the silent failures when pushing container images (devfile/api#1328).Which issue(s) this PR fixes:
Fixes #?
fixes part of devfile/api#1267
fixes devfile/api#1328
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: