Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Fixes to README.md and CONTRIBUTING.md #59

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Nov 8, 2023

Please specify the area for this PR
Typo Fix
What does does this PR do / why we need it:
Updates the README.md and CONTRIBUTING.md to reflect typo fixes discovered when reading through the documentation.
Which issue(s) this PR fixes:
N/A

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@openshift-ci openshift-ci bot requested review from rm3l and thepetk November 8, 2023 19:45
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d49fee6) 26.43% compared to head (08185bf) 25.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   26.43%   25.86%   -0.57%     
==========================================
  Files          25       25              
  Lines        1415     1415              
==========================================
- Hits          374      366       -8     
- Misses       1020     1026       +6     
- Partials       21       23       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
@Jdubrick Jdubrick merged commit b4ddb0d into devfile:main Nov 9, 2023
8 of 9 checks passed
thepetk pushed a commit to thepetk/devfile-registry-operator that referenced this pull request Aug 20, 2024
* update typos in contributing.md

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* fix typo in readme

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

---------

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants