Patch k8s and disable http/2 by default to mitigate rapid reset CVE #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
requested review from
johnmcollier,
thepetk,
maysunfaisal and
kim-tsao
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 26.43% 25.30% -1.14%
==========================================
Files 25 25
Lines 1415 1415
==========================================
- Hits 374 358 -16
- Misses 1020 1032 +12
- Partials 21 25 +4 ☔ View full report in Codecov by Sentry. |
maysunfaisal
approved these changes
Nov 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
thepetk
pushed a commit
to thepetk/devfile-registry-operator
that referenced
this pull request
Aug 20, 2024
…evfile#60) * patch dependencies Signed-off-by: Michael Valdron <mvaldron@redhat.com> * disable http/2 by default Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add instructions to enable http/2 Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
PR changes include patching of the k8s dependencies, patch for kubebuilder, and disabling of http/2 by default with optional toggle to enable by choice. Changes match what was done for the application service operator redhat-appstudio/application-service#403.
Mitigates CVE-2023-44487
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1307
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: