Implement Podman scripts for Registry-Operator Makefile #61
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
README.md
Outdated
| | podman-build | build registry operator podman image | | ||
| | podman-push | push registry operator podman image | |
There was a problem hiding this comment.
I would phase it "build registry operator container image using <engine>"
| | podman-build | build registry operator podman image | | |
| | podman-push | push registry operator podman image | | |
| | podman-build | build registry operator container image using podman | | |
| | podman-push | push registry operator container image using podman | |
There was a problem hiding this comment.
@michael-valdron updated the wording in the most recent commit to reflect the engine being used for building/pushing the images
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 26.43% 26.43%
=======================================
Files 25 25
Lines 1415 1415
=======================================
Hits 374 374
Misses 1020 1020
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update documentation for podman support Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update Makefile to add podman commands Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update readme wording for engine being used Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
Registry-Operator
What does does this PR do / why we need it:
Implements podman script support for the Registry-Operator build and push commands
Which issue(s) this PR fixes:
Fixes #?
resolves devfile/api#1340
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer:
Run the new commands via CLI to build and push images created with podman instead of docker