-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon base64data and code block formatting in CSV files #62
Fix icon base64data and code block formatting in CSV files #62
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
N/A |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 25.30% 26.43% +1.13%
==========================================
Files 25 25
Lines 1415 1415
==========================================
+ Hits 358 374 +16
+ Misses 1032 1020 -12
+ Partials 25 21 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general lgtm only left a minor comment. If we are ok I'll approve!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
It is reported in devfile/api#1354 that the icon is missing and code blocks are not formatting correctly under the embedded OperatorHub catalog in OpenShift. These changes mirror the formatting of the strings used in other bundle entries with expected results which should correct these problems.
Testing these changes under the OperatorHub.io preview tool does not break the currently working page.
Note: These changes require a patch version to be cut before devfile/api#1354 can be resolved.
Which issue(s) this PR fixes:
Fixes #?
devfile/api#1354
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: