Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CHANGELOG section #69

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

documentation

What does does this PR do / why we need it:

Since CHANGELOG.md no longer exists in favour of using release notes, the section for it should be removed.

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

N/A

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (deec778) 25.86% compared to head (1698460) 26.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   25.86%   26.43%   +0.56%     
==========================================
  Files          25       25              
  Lines        1415     1415              
==========================================
+ Hits          366      374       +8     
+ Misses       1026     1020       -6     
+ Partials       23       21       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor

Jdubrick commented Dec 19, 2023

I'm curious as CHANGELOG is going to be required for our CLO Monitor: https://clomonitor.io/docs/topics/checks/#changelog

I suppose we could exempt it and state we are using release notes, but what do you think? @michael-valdron

edit: is it possible to leave the changelog section in our readme and link out to release notes?

@michael-valdron
Copy link
Member Author

I'm curious as CHANGELOG is going to be required for our CLO Monitor: https://clomonitor.io/docs/topics/checks/#changelog

I suppose we could exempt it and state we are using release notes, but what do you think? @michael-valdron

edit: is it possible to leave the changelog section in our readme and link out to release notes?

I agree, lets close this PR to address this separately.

@michael-valdron
Copy link
Member Author

I'm curious as CHANGELOG is going to be required for our CLO Monitor: https://clomonitor.io/docs/topics/checks/#changelog
I suppose we could exempt it and state we are using release notes, but what do you think? @michael-valdron
edit: is it possible to leave the changelog section in our readme and link out to release notes?

I agree, lets close this PR to address this separately.

We should address these changes as part of devfile/api#1386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants