-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CHANGELOG section #69
Remove CHANGELOG section #69
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
N/A |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 25.86% 26.43% +0.56%
==========================================
Files 25 25
Lines 1415 1415
==========================================
+ Hits 366 374 +8
+ Misses 1026 1020 -6
+ Partials 23 21 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm curious as I suppose we could exempt it and state we are using release notes, but what do you think? @michael-valdron edit: is it possible to leave the changelog section in our readme and link out to release notes? |
I agree, lets close this PR to address this separately. |
We should address these changes as part of devfile/api#1386 |
Please specify the area for this PR
documentation
What does does this PR do / why we need it:
Since
CHANGELOG.md
no longer exists in favour of using release notes, the section for it should be removed.Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: