-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingressClass CRD field #79
Add ingressClass CRD field #79
Conversation
@michael-valdron two qq:
|
Should match helm chart's default value (
Not yet, this is to be done in devfile/api#1435. devfile/api#1434 is just covers the CRD, could also do accessor functions under cc: @thepetk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 27.10% 26.23% -0.87%
==========================================
Files 25 25
Lines 1428 1433 +5
==========================================
- Hits 387 376 -11
- Misses 1020 1032 +12
- Partials 21 25 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think similar changes to defaults.go
under #76 should be done here as well.
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
177ea6a
to
821b9ad
Compare
Done! |
@michael-valdron I feel the code coverage check could be skipped as is only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thepetk Yeah I think your test coverage is sufficient here. |
* Add ingressClass field Signed-off-by: thepetk <thepetk@gmail.com> * Update description for ingressClass Signed-off-by: thepetk <thepetk@gmail.com> * Update defaults with k8s ingress class Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
This PR adds support for the CRD field of the ingress class in the
registry-operator
.What does does this PR do / why we need it:
fixes devfile/api#1434
Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: