Enable the metrics endpoint on the OCI registry container #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the Prometheus metrics endpoint on the OCI registry server. This is done via exporting the server config to a configmap, allowing the registry operator to set the Also does some refactoring of the ensure code. Signed-off-by: John Collier <jcollier@redhat.com>
3 tasks
GeekArthur
approved these changes
Jan 12, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GeekArthur, johnmcollier The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Prometheus metrics endpoint on the OCI registry server. This is done via exporting the OCI server config to a configmap, allowing the registry operator to configure it. This will be handy in the future, should any additional configurations on the OCI server need to be done.
Also, the refactoring of the
ensure.gofunctions has been done, as described by @GeekArthur in #2 (comment).The metrics endpoint is not publicly exposed. I've pushed the operator image up to my dockerhub account for testing. To Test:
make install IMG=johncollier/registry-operator:latestmake deploy IMG=johncollier/registry-operator:latestoc apply -f registry.yamloc exec <registry-pod> -c devfile-registry-bootstrap -- curl localhost:5001/metrics(the OCI server doesn't have curl installed, so we're using the index/bootstrap container to run the command)Signed-off-by: John Collier jcollier@redhat.com