Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ingress and Hostname #80

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Mar 5, 2024

Please specify the area for this PR

What does does this PR do / why we need it:
This PR updates the operator hostname to be consistent in its definition between the Helm deployment and the openshift deployment. Prior to this change the Helm chart implemented the CR name coupled with the namespace to create the hostname whereas the openshift deployment only used the CR name and the ingress.

Additionally the readme was updated with a Known Issues section as during testing I was trying to run make test-integration on Minikube, however, it was timing out and I could not figure out why this was happening. There was an active issue that outlined this and it would be good for others to be aware of known issues such as this in the future.

Some unit tests were also added to verify that the functions used to generate the combination of the hostname/ingress/name are working as intended.

Which issue(s) this PR fixes:

fixes devfile/api#1431

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

  • make test passes
  • make test-integration passes

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick
Copy link
Contributor Author

Jdubrick commented Mar 5, 2024

/test v4.12-registry-operator-integration-test

README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.34%. Comparing base (7c6b2a6) to head (4a75101).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   26.43%   27.34%   +0.91%     
==========================================
  Files          25       25              
  Lines        1415     1430      +15     
==========================================
+ Hits          374      391      +17     
+ Misses       1020     1018       -2     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jordan Dubrick <dubrickjordan@gmail.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2024
Copy link

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit 24724a1 into devfile:main Mar 6, 2024
11 checks passed
thepetk pushed a commit to thepetk/devfile-registry-operator that referenced this pull request Aug 20, 2024
* update ingress hostname

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

* update known issues

Signed-off-by: Jordan Dubrick <dubrickjordan@gmail.com>

---------

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <dubrickjordan@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants