Feature: Fully Qualified App Name

[michael-valdron]

Please specify the area for this PR

operator

What does does this PR do / why we need it:

Adds the fully qualified app name found under the helm chart and refactors to match usage. Additionally adds truncation to both app name and fully qualified app name as seen in the helm chart.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1441, devfile/api#1442

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

A reviewer will need to run these commands to run the integration tests locally or else the make test-integration will likely fail:

1. Run make install-cert
2. Wait for cert-manager to be ready, its under the cert-manager namespace
3. Run make install && make deploy
4. Wait for registry-operator to be ready, its under the registry-operator-system namespace
5. Run make test-integration

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[michael-valdron]

Review status is waiting to resolve an issue discovered during testing: devfile/api#1441 (comment)

[michael-valdron]

Does the registry operator documentation need to be updated with your changes?

Out of issue scope.

[Jdubrick]

Unit tests are passing for me - Waiting on a cluster to spin up so I can run the integration tests because they don't want to work on my local crc

[michael-valdron]

Unit tests are passing for me - Waiting on a cluster to spin up so I can run the integration tests because they don't want to work on my local crc

@Jdubrick Updated the reviewer notes on the PR description with the steps to ensure make test-integration runs properly.

[Jdubrick]

/lgtm

All unit and integration tests are passing for me. I'm okay with it being merged but if @thepetk wants to take a look before that's okay with me.

[thepetk]

Overall looks good to me, left only a minor question

[thepetk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment