-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Fully Qualified App Name #86
Feature: Fully Qualified App Name #86
Conversation
Skipping CI for Draft Pull Request. |
Review status is waiting to resolve an issue discovered during testing: devfile/api#1441 (comment) |
…r app name getter changes Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…of CR name Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…d space for suffix part Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
… OpenShift route url Signed-off-by: Michael Valdron <mvaldron@redhat.com>
1101b15
to
8582b42
Compare
Out of issue scope. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ame devfile-registry Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Unit tests are passing for me - Waiting on a cluster to spin up so I can run the integration tests because they don't want to work on my local crc |
@Jdubrick Updated the reviewer notes on the PR description with the steps to ensure |
/lgtm All unit and integration tests are passing for me. I'm okay with it being merged but if @thepetk wants to take a look before that's okay with me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, left only a minor question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* app name functions and refactored devfile registry labels function for app name getter changes Signed-off-by: Michael Valdron <mvaldron@redhat.com> * truncateName & LabelsForDevfileRegistry test cases Signed-off-by: Michael Valdron <mvaldron@redhat.com> * app name getter test cases Signed-off-by: Michael Valdron <mvaldron@redhat.com> * refactor naming.go functions to use fully qualified app name instead of CR name Signed-off-by: Michael Valdron <mvaldron@redhat.com> * change truncated length of app full name part of configmap name to add space for suffix part Signed-off-by: Michael Valdron <mvaldron@redhat.com> * naming function getter test cases Signed-off-by: Michael Valdron <mvaldron@redhat.com> * truncateName & truncateNameLengthN comment blocks Signed-off-by: Michael Valdron <mvaldron@redhat.com> * k8s ingress host name uses app full name rather than CR name to match OpenShift route url Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix full name contains case Signed-off-by: Michael Valdron <mvaldron@redhat.com> * fix given CR names in integration test cases to contain default app name devfile-registry Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
operator
What does does this PR do / why we need it:
Adds the fully qualified app name found under the helm chart and refactors to match usage. Additionally adds truncation to both app name and fully qualified app name as seen in the helm chart.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1441, devfile/api#1442
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer:
A reviewer will need to run these commands to run the integration tests locally or else the
make test-integration
will likely fail:make install-cert
cert-manager
namespacemake install && make deploy
registry-operator-system
namespacemake test-integration