Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup-envtest version #87

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Apr 11, 2024

Please specify the area for this PR

operator
test

What does does this PR do / why we need it:

Fixes sigs.k8s.io/controller-runtime/tools/setup-envtest to revision v0.0.0-20240405143037-c25fe2f5ca0f to workaround kubernetes-sigs/controller-runtime#2744.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1519

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

Does the registry operator documentation need to be updated with your changes?

N/A

@michael-valdron michael-valdron merged commit c385aba into devfile:main Apr 11, 2024
9 checks passed
thepetk pushed a commit to thepetk/devfile-registry-operator that referenced this pull request Aug 20, 2024
…ntime#2744 (devfile#87)

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry operator fails on unit tests
2 participants