Update Testing Documentation #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
There was a problem hiding this comment.
Changes looks good.
We should include a note for the integration test instructions stating this is subject to change when devfile/api#1523 is resolved.
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
I added a comment as a reminder. |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thepetk
pushed a commit
to thepetk/devfile-registry-operator
that referenced
this pull request
Aug 20, 2024
* update documentation for testing the operator Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * update pr template for testing changes Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * make reference to files consistent cases Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * add comment as reminder to update docs Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> * link test instructions in pr template to contributing Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> --------- Signed-off-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
Documentation updates
What does does this PR do / why we need it:
This PR updates the documentation for how to properly test the Devfile Registry Operator. This also updates the PR template to include these instructions so reviewers will always have that information readily available.
Which issue(s) this PR fixes:
No issue
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: