Update go version to 1.21

[thepetk]

Please specify the area for this PR

registry-operator

What does does this PR do / why we need it:

This PR upgrades the go version from 1.19 to 1.21 and the k8s.io/api from 0.26.10 to 0.29.2.

It also includes the necessary refactoring, mostly coming from the necessary bump up of the controller-runtime.

Which issue(s) this PR fixes:

Fixes devfile/api#1559

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
• Gosec scans
  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to be updated with your changes?

Testing changes

Running Unit Tests

Running Integration Tests

Special notes to the reviewer:

[openshift-ci]

@thepetk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.12-registry-operator-integration-test	3686ef3	link	true	/test v4.12-registry-operator-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Jdubrick]

It's possible it isn't reading the go version properly in the failed test. We could try logging the go env to see what its looking for

[michael-valdron]

It's possible it isn't reading the go version properly in the failed test. We could try logging the go env to see what its looking for

Changes here might fix this failed check.

FYI @Jdubrick

[thepetk]

It's possible it isn't reading the go version properly in the failed test. We could try logging the go env to see what its looking for

Changes here might fix this failed check.

FYI @Jdubrick

Yes I was thinking about this process because it's a bit complicated. AFAIK we need to merge first the openshift release PR, then we will get the 4.15 checks and then if they are ok we can merge the current PR right?

[Jdubrick]

It's possible it isn't reading the go version properly in the failed test. We could try logging the go env to see what its looking for

Changes here might fix this failed check.
FYI @Jdubrick

Yes I was thinking about this process because it's a bit complicated. AFAIK we need to merge first the openshift release PR, then we will get the 4.15 checks and then if they are ok we can merge the current PR right?

That sounds like the most likely workflow to me, it doesn't hurt to do the openshift release PR first and see what happens. At the very least we know there is something more on this PR to debug if it doesn't address the issue

[thepetk]

@michael-valdron @Jdubrick Now that the openshift/release#53498 is merged I see the statuses are ok

[Jdubrick]

/lgtm

[michael-valdron]

/lgtm

Builds and deploys successfully 👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment