Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts to work with podman #101

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Feb 11, 2022

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Updates the scripts and READMEs to use podman as an alternative. In order to have the alias command to run consistently, I had to source the scripts in ./build_registry.sh so they would all run under the same shell.

Which issue(s) this PR fixes:

Fixes #?
devfile/api#766

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:

set the environment variable USE_PODMAN=true and run the main build script ./build_registry.sh

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2022

@kim-tsao: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Updates the scripts and READMEs to use podman as an alternative. In order to have the alias command to run consistently, I had to source the scripts in ./build_registry.sh so they would all run under the same shell.

Which issue(s) this PR fixes:

Fixes #?
devfile/api#766

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:

set the environment variable USE_PODMAN=true and run the main build script ./build_registry.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@kim-tsao kim-tsao merged commit dbd6c68 into devfile:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants