Update telemetry enablement #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Tsao <ktsao@redhat.com>
johnmcollier
requested changes
Mar 7, 2022
| registryName: "devfile-registry" | ||
| key: "6HBMiy5UxBtsbxXx7O4n0t0u4dt8IAR3" |
There was a problem hiding this comment.
Should this be unset instead?
There was a problem hiding this comment.
yes, let me update that
Signed-off-by: Kim Tsao <ktsao@redhat.com>
johnmcollier
approved these changes
Mar 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kim Tsao ktsao@redhat.com
Please specify the area for this PR
Removes the hardcoded segment write key
What does does this PR do / why we need it:
We do not want to be collecting telemetry from users who set up their own devfile registries (per CNCF telemetry data policy). They should be sending telemetry to their own Segment instance
Which issue(s) this PR fixes:
Fixes #?
devfile/api#769
PR acceptance criteria:
Test (WIP)
Documentation (WIP)
How to test changes / Special notes to the reviewer: