-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update telemetry enablement #104
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, can you also update the registry chart's readme to reference the new values.telemetry.key
field?
registryName: "devfile-registry" | ||
key: "6HBMiy5UxBtsbxXx7O4n0t0u4dt8IAR3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be unset instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, let me update that
Signed-off-by: Kim Tsao <ktsao@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kim Tsao ktsao@redhat.com
Please specify the area for this PR
Removes the hardcoded segment write key
What does does this PR do / why we need it:
We do not want to be collecting telemetry from users who set up their own devfile registries (per CNCF telemetry data policy). They should be sending telemetry to their own Segment instance
Which issue(s) this PR fixes:
Fixes #?
devfile/api#769
PR acceptance criteria:
Test (WIP)
Documentation (WIP)
How to test changes / Special notes to the reviewer: