Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update #113

Merged
merged 4 commits into from
May 5, 2022
Merged

docs update #113

merged 4 commits into from
May 5, 2022

Conversation

yangcao77
Copy link
Contributor

@yangcao77 yangcao77 commented May 3, 2022

Signed-off-by: Stephanie yangcao@redhat.com

Please specify the area for this PR
registry-library doc
registry server doc

What does does this PR do / why we need it:
This PR updates the registry library doc with v2index changes.
also move the registry server REST API change to this repo, the landing page should point to this link afterwards

Which issue(s) this PR fixes:

devfile/api#838

PR acceptance criteria:

  • Test (WIP)

  • Documentation (WIP)

How to test changes / Special notes to the reviewer:

…s repo

Signed-off-by: Stephanie <yangcao@redhat.com>
@openshift-ci openshift-ci bot requested a review from maysunfaisal May 3, 2022 19:42
@yangcao77 yangcao77 changed the title add v2index change in library readme, move server rest api doc to thi… docs update May 3, 2022
@yangcao77
Copy link
Contributor Author

yangcao77 commented May 3, 2022

@michael-valdron can you help add the starter project changes to those two docs as well? Thanks

Signed-off-by: Stephanie <yangcao@redhat.com>
@michael-valdron
Copy link
Member

@michael-valdron can you help add the starter project changes to those two docs as well? Thanks

Done!

@kim-tsao
Copy link
Contributor

kim-tsao commented May 5, 2022

@michael-valdron can you help add the starter project changes to those two docs as well? Thanks

Done!

@michael-valdron can you also update this doc? https://github.com/devfile/registry-support/blob/main/registry-library/README.md It's the documentation for the registry library API

@yangcao77
Copy link
Contributor Author

@kim-tsao Micheal did not update the registry library, so no need to update that doc. but perhaps an API should be introduced to the library for starterprojects @michael-valdron @johnmcollier Any thoughts?

@michael-valdron
Copy link
Member

michael-valdron commented May 5, 2022

@michael-valdron can you help add the starter project changes to those two docs as well? Thanks

Done!

@michael-valdron can you also update this doc? https://github.com/devfile/registry-support/blob/main/registry-library/README.md It's the documentation for the registry library API

For Starter Projects I did not update the registry-library, @yangcao77 and I only updated the following:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@yangcao77
Copy link
Contributor Author

yangcao77 commented May 5, 2022

@michael-valdron since registry library is just providing library API to interact with registry server, it should reflect all features that REST APIs provide. I do think we need to include the starterproject APIs in registry library. So tools like odo can start consuming the registry library APi, instead of creating their own.

@kim-tsao @johnmcollier @elsony what do you guys think?

@elsony
Copy link
Contributor

elsony commented May 5, 2022

@michael-valdron since registry library is just providing library API to interact with registry server, it should reflect all features that REST APIs provide. I do think we need to include the starterproject APIs in registry library. So tools like odo can start consuming the registry library APi, instead of creating their own.

In general, our library API should minor the function of the REST API. So +1 on adding that as part of the library.

@kim-tsao
Copy link
Contributor

kim-tsao commented May 5, 2022

@michael-valdron since registry library is just providing library API to interact with registry server, it should reflect all features that REST APIs provide. I do think we need to include the starterproject APIs in registry library. So tools like odo can start consuming the registry library APi, instead of creating their own.

In general, our library API should minor the function of the REST API. So +1 on adding that as part of the library.

I agree

@johnmcollier
Copy link
Member

johnmcollier commented May 5, 2022

I won't pile on to the plus 1s 🙂 , but can we get an issue open for the registry library changes?

Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the doc is pretty good but should we consider truncating some of the lengthier responses? Should we also have a table of contents so that users can directly navigate to the API they want?


=== Request body
The request body must be empty.
=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, Request Example subheading is not formatted properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


=== Request body
The request body must be empty.
=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, Request Example subheading is not formatted properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77
Copy link
Contributor Author

In general, the doc is pretty good but should we consider truncating some of the lengthier responses? Should we also have a table of contents so that users can directly navigate to the API they want?

Good point. I added a navigation table at top of the doc. Can you review it as well?

@kim-tsao
Copy link
Contributor

kim-tsao commented May 5, 2022

In general, the doc is pretty good but should we consider truncating some of the lengthier responses? Should we also have a table of contents so that users can directly navigate to the API they want?

Good point. I added a navigation table at top of the doc. Can you review it as well?

yes, I'll review it

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, yangcao77
To complete the pull request process, please assign maysunfaisal after the PR has been reviewed.
You can assign the PR to them by writing /assign @maysunfaisal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member

I won't pile on to the plus 1s slightly_smiling_face , but can we get an issue open for the registry library changes?

devfile/api#842

@johnmcollier @yangcao77 @kim-tsao @elsony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants