Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to oras.land/oras-go v1.1.0 #117

Merged
merged 2 commits into from
May 27, 2022

Conversation

dperaza4dustbit
Copy link
Contributor

What does does this PR do / why we need it:
Updates the ORAS dependency to oras.land/oras-go v1.1.0 to fix the dependency collision between devfile and ODC.

Which issue(s) this PR fixes:
Fixes devfile/api#854

Signed-off-by: David Peraza dperaza@redhat.com

Updates the ORAS dependency to oras.land/oras-go v1.1.0 to fix the dependency collision between devfile and ODC.

Which issue(s) this PR fixes:

Fixes devfile/api#854

Signed-off-by: David Peraza <dperaza@redhat.com>
@dperaza4dustbit
Copy link
Contributor Author

I can build and test:

dperaza@dperaza-mac registry-library % ./build.sh 
dperaza@dperaza-mac registry-library % cd library 
dperaza@dperaza-mac library % go test
PASS
ok      github.com/devfile/registry-support/registry-library/library    0.356s

@johnmcollier
Copy link
Member

johnmcollier commented May 26, 2022

Library Build failing in the CI with

Run cd registry-library && ./build.sh
# golang.org/x/net/http2
Error: vendor/golang.org/x/net/http2/transport.go:417:45: undefined: os.ErrDeadlineExceeded
Error: Process completed with exit code 2.

@dperaza4dustbit Can you update the go version in our ci.yaml to Go 1.17?

and

@dperaza4dustbit
Copy link
Contributor Author

Library Build failing in the CI with

Run cd registry-library && ./build.sh
# golang.org/x/net/http2
Error: vendor/golang.org/x/net/http2/transport.go:417:45: undefined: os.ErrDeadlineExceeded
Error: Process completed with exit code 2.

@dperaza4dustbit Can you update the go version in our ci.yaml to Go 1.17?

and

will do, that explains why it works on my client, thanks

Signed-off-by: David Peraza <dperaza@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, johnmcollier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@johnmcollier johnmcollier merged commit 8328a8a into devfile:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants