Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check for tests against staging #123

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

johnmcollier
Copy link
Member

@johnmcollier johnmcollier commented Jun 21, 2022

  • I skipped the wrong set of tests in Skip offline test cases for registry acceptance tests #121 🤦, this PR skips the right set of tests:

    •••••
    Ran 26 of 37 Specs in 11.266 seconds
    SUCCESS! -- 26 Passed | 0 Failed | 0 Pending | 11 Skipped
    PASS
    
  • Adds a new PR check that runs the tests against staging, to ensure they pass as well (as these tests are used in the acceptance tests for promotions)

Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@johnmcollier johnmcollier changed the title Actuallyfixteststhistime Add CI check for tests against staging Jun 21, 2022
@johnmcollier johnmcollier requested review from michael-valdron and removed request for elsony and maysunfaisal June 21, 2022 14:09
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier johnmcollier merged commit a7d0871 into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants