-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubDir non-existent destination bug fix #124
SubDir non-existent destination bug fix #124
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…enamed to 'Maven Java'. 'Maven Java (with subdir)' rewritten to test 'Wildfly Java - microprofile-config subdirectory'. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about what will be in the cached zip:
Will the cached starter project be (folders included):
quickstart/microprofile-config
Or just
microprofile-config
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
It will be in the end |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron mvaldron@redhat.com
Please specify the area for this PR
registry-support/index/generator
What does does this PR do / why we need it:
Changes in this PR provides the extra process of creating the base directory, if non-existent, for the operation performed by
copyFileWithFs
on index/generator/libraryutil.go#L223. Without this, certain starter project downloads such as Java Wildfly fail with an error seen in devfile/api#867.Additional changes include an additional test case which includes the Java Wildfly starter project to perform further testing on starter project downloads using the
subDir
property.Which issue(s) this PR fixes:
Fixes #?
partially fixes devfile/api#867
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: