SubDir non-existent destination bug fix

[michael-valdron]

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR
registry-support/index/generator

What does does this PR do / why we need it:

Changes in this PR provides the extra process of creating the base directory, if non-existent, for the operation performed by copyFileWithFs on index/generator/libraryutil.go#L223. Without this, certain starter project downloads such as Java Wildfly fail with an error seen in devfile/api#867.

Additional changes include an additional test case which includes the Java Wildfly starter project to perform further testing on starter project downloads using the subDir property.

Which issue(s) this PR fixes:

Fixes #?
partially fixes devfile/api#867

PR acceptance criteria:

• Test (WIP)

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

cd index/generator
go test -v ./...

[johnmcollier]

I'm a little confused about what will be in the cached zip:

Will the cached starter project be (folders included):

quickstart/microprofile-config

Or just

microprofile-config

[michael-valdron]

I'm a little confused about what will be in the cached zip:

Will the cached starter project be (folders included):

quickstart/microprofile-config

Or just

microprofile-config

It will be in the end quickstart/microprofile-config, the process for downloading git goes through a multi-step process before archiving. In the last step, it appears that it is archiving the entire quickstart but it is the contents of quickstart/microprofile which have been separated.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnmcollier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment