Minor changes to the download cmd in handling the context path and bug fixes

[michael-valdron]

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR
registry library

What does does this PR do / why we need it:

Recently added in PR #126, the registry download command downloads and extracts a starter project to a given context path (default .). At this time, it will create a sub-directory under the context path to extract the starter project contents to, however, it would be more useful and consistent with registry pull to extract the contents directly into the context path itself which is what this PR intents to provide.

After this change, one can still create a sub-directory by specifying --context=./<subdirectory_name>.

Other Changes:

• Bug fix to DownloadStarterProjectAsDir extract ZipSlip check, if the entire resultant file path is the just the file name (no directory prefix) do not perform check.
  • Without this fix the function will error in all cases of using the relative path to the present working directory ..
• Bug fix to DownloadStarterProjectAsBytes not downloading correctly if base registry url ends with /

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#892
fixes devfile/api#895

PR acceptance criteria:

• Test (WIP)

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

[johnmcollier]

Generally looks good. Do we need to add test cases for the bugfixes, or are the updates sufficient?

[michael-valdron]

Generally looks good. Do we need to add test cases for the bugfixes, or are the updates sufficient?

@johnmcollier Oh you mean test cases which say for example test that https://registry.devfile.io and https://registry.devfile.io/ work the same or context = . does not error?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnmcollier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment