-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes to the download cmd in handling the context path and bug fixes #128
Minor changes to the download cmd in handling the context path and bug fixes #128
Conversation
…self instead of a subdirectory. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Do we need to add test cases for the bugfixes, or are the updates sufficient?
@johnmcollier Oh you mean test cases which say for example test that |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
df1aa2c
to
b47de73
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Valdron mvaldron@redhat.com
Please specify the area for this PR
registry library
What does does this PR do / why we need it:
Recently added in PR #126, the
registry download
command downloads and extracts a starter project to a given context path (default.
). At this time, it will create a sub-directory under the context path to extract the starter project contents to, however, it would be more useful and consistent withregistry pull
to extract the contents directly into the context path itself which is what this PR intents to provide.After this change, one can still create a sub-directory by specifying
--context=./<subdirectory_name>
.Other Changes:
DownloadStarterProjectAsDir
extract ZipSlip check, if the entire resultant file path is the just the file name (no directory prefix) do not perform check..
.DownloadStarterProjectAsBytes
not downloading correctly if base registry url ends with/
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#892
fixes devfile/api#895
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: