Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track telemetry download events for GET requests only #132

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

kim-tsao
Copy link
Contributor

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
The proxy endpoint handles GET and HEAD requests which is contributing to duplicate download calls (in some cases, like the go devfile). This should reduce the number of actions we're receiving in Segment

Which issue(s) this PR fixes:

Fixes #?
devfile/api#888

PR acceptance criteria:

  • [x ] Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

  • built and deployed devfile-index image with fix and observed one download event passing through Segment for Go devfile (used odo init to trigger download)
  • deployed latest prod devfile-index (without fix) and observed two download events for Go devfile, one download event for python and java-maven

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2022

@kim-tsao: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
The proxy endpoint handles GET and HEAD requests which is contributing to duplicate download calls (in some cases, like the go devfile). This should reduce the number of actions we're receiving in Segment

Which issue(s) this PR fixes:

Fixes #?
devfile/api#888

PR acceptance criteria:

  • [x ] Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

  • built and deployed devfile-index image with fix and observed one download event passing through Segment for Go devfile (used odo init to trigger download)
  • deployed latest prod devfile-index (without fix) and observed two download events for Go devfile, one download event for python and java-maven

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@kim-tsao kim-tsao merged commit 4e2a0cb into devfile:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants