-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License updates #140
License updates #140
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Codecov ReportBase: 43.46% // Head: 43.46% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 43.46% 43.46%
=======================================
Files 6 6
Lines 971 971
=======================================
Hits 422 422
Misses 508 508
Partials 41 41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggestion
Signed-off-by: Kim Tsao <ktsao@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
What does does this PR do / why we need it:
This PR adds the following:
Which issue(s) this PR fixes:
Fixes #?
devfile/api#931
PR acceptance criteria:
Documentation (WIP)
N/A
How to test changes / Special notes to the reviewer: