Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License updates #140

Merged
merged 5 commits into from
Sep 22, 2022
Merged

License updates #140

merged 5 commits into from
Sep 22, 2022

Conversation

kim-tsao
Copy link
Contributor

Please specify the area for this PR

What does does this PR do / why we need it:
This PR adds the following:

  • license headers in go files
  • license check to our workflow

Which issue(s) this PR fixes:

Fixes #?
devfile/api#931

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

N/A
How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao changed the title License License updates Sep 19, 2022
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Base: 43.46% // Head: 43.46% // No change to project coverage 👍

Coverage data is based on head (49ce947) compared to base (36887a7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   43.46%   43.46%           
=======================================
  Files           6        6           
  Lines         971      971           
=======================================
  Hits          422      422           
  Misses        508      508           
  Partials       41       41           
Impacted Files Coverage Δ
index/server/pkg/server/endpoint.go 35.25% <ø> (ø)
index/server/pkg/server/index.go 9.62% <ø> (ø)
index/server/pkg/server/registry.go 28.37% <ø> (ø)
index/server/pkg/util/filter.go 86.66% <ø> (ø)
index/server/pkg/util/telemetry.go 79.10% <ø> (ø)
index/server/pkg/util/util.go 63.63% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion

add_licenses.sh Outdated Show resolved Hide resolved
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@kim-tsao kim-tsao merged commit 343c4c5 into devfile:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants