Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gosec enablement #142

Merged
merged 7 commits into from
Oct 13, 2022
Merged

gosec enablement #142

merged 7 commits into from
Oct 13, 2022

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Oct 7, 2022

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR

What does does this PR do / why we need it:

  • enables gosec in githubs actions
  • adds rule to Makefile

Which issue(s) this PR fixes:

Fixes #?

devfile/api#937

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 43.46% // Head: 43.14% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (c3c2a80) compared to base (f17c2bf).
Patch coverage: 17.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   43.46%   43.14%   -0.32%     
==========================================
  Files           6        6              
  Lines         971      985      +14     
==========================================
+ Hits          422      425       +3     
- Misses        508      519      +11     
  Partials       41       41              
Impacted Files Coverage Δ
index/server/pkg/server/endpoint.go 35.17% <0.00%> (-0.08%) ⬇️
index/server/pkg/server/index.go 9.02% <0.00%> (-0.61%) ⬇️
index/server/pkg/server/registry.go 28.37% <ø> (ø)
index/server/pkg/util/util.go 63.92% <75.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2022
@kim-tsao kim-tsao marked this pull request as ready for review October 13, 2022 18:13
@kim-tsao
Copy link
Contributor Author

I forgot to put it in review but thanks for approving @maysunfaisal . Can I get a quick approval again?

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 83052e3 into devfile:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants