Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort devfile versions in descending order #144

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

schultzp2020
Copy link
Contributor

Please specify the area for this PR

/area registry

What does does this PR do / why we need it:

  1. Sorts devfile versions in descending order on generation.
  2. Adds a .gitattributes file to enforce lf carriage returns.

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2022

@schultzp2020: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area registry

What does does this PR do / why we need it:

  1. Sorts devfile versions in descending order on generation.
  2. Adds a .gitattributes file to enforce lf carriage returns.

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: Paul Schultz <pschultz@pobox.com>
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 43.46% // Head: 43.46% // No change to project coverage 👍

Coverage data is based on head (37035ff) compared to base (343c4c5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   43.46%   43.46%           
=======================================
  Files           6        6           
  Lines         971      971           
=======================================
  Hits          422      422           
  Misses        508      508           
  Partials       41       41           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@michael-valdron michael-valdron self-assigned this Oct 12, 2022
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, schultzp2020
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval by writing /assign @maysunfaisal in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit f17c2bf into devfile:main Oct 12, 2022
@schultzp2020 schultzp2020 deleted the sort-devfile-versions branch October 12, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants