Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to library 2.0.1 #145

Merged
merged 2 commits into from
Oct 18, 2022
Merged

update to library 2.0.1 #145

merged 2 commits into from
Oct 18, 2022

Conversation

yangcao77
Copy link
Contributor

Signed-off-by: Stephanie yangcao@redhat.com

Please specify the area for this PR

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 43.14% // Head: 43.14% // No change to project coverage 👍

Coverage data is based on head (f6b97b7) compared to base (83052e3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   43.14%   43.14%           
=======================================
  Files           6        6           
  Lines         985      985           
=======================================
  Hits          425      425           
  Misses        519      519           
  Partials       41       41           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77 yangcao77 changed the title update to library 2.0.0 update to library 2.0.1 Oct 18, 2022
Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77 yangcao77 marked this pull request as ready for review October 18, 2022 19:25
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, yangcao77
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval by writing /assign @johnmcollier in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit df96d34 into devfile:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants