Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object property name changes for NEXT_PUBLIC_DEVFILE_REGISTRIES #152

Merged

Conversation

michael-valdron
Copy link
Member

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR

What does does this PR do / why we need it: Recent changes to the Registry Viewer now needs the following object property name changes within the JSON stored in the environment variable NEXT_PUBLIC_DEVFILE_REGISTRIES:

  • link is now url
  • alias is now fqdn

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#747

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 43.92% // Head: 43.92% // No change to project coverage 👍

Coverage data is based on head (66fa9f7) compared to base (95f8575).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files           6        6           
  Lines        1020     1020           
=======================================
  Hits          448      448           
  Misses        530      530           
  Partials       42       42           
Impacted Files Coverage Δ
index/server/pkg/util/telemetry.go 72.60% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, schultzp2020
Once this PR has been reviewed and has the lgtm label, please assign elsony for approval by writing /assign @elsony in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 19293ac into devfile:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants