Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Viewer envfile configmap #153

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Dec 8, 2022

Please specify the area for this PR

What does does this PR do / why we need it:

Replaces environment variable definitions for the registry viewer with environment variable file content in the configmap.yamlfor the helm chart, this is a requirement for the registry viewer analytics write key to be set.

Additional Changes

Sets the required security context for the registry viewer container, currently needed for OpenShift 4.12 deployments.

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#747

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 43.92% // Head: 43.92% // No change to project coverage 👍

Coverage data is based on head (aadda67) compared to base (19293ac).
Patch has no changes to coverable lines.

❗ Current head aadda67 differs from pull request most recent head da7dbee. Consider uploading reports for the commit da7dbee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files           6        6           
  Lines        1020     1020           
=======================================
  Hits          448      448           
  Misses        530      530           
  Partials       42       42           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…lias field in configmap object .env.registry-viewer

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Copy link
Member Author

Need to apply fixes to Dockerfiles for non root support in minikube

@michael-valdron
Copy link
Member Author

blocked by #154

@johnmcollier johnmcollier marked this pull request as ready for review December 20, 2022 16:20
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@michael-valdron michael-valdron merged commit cab341c into devfile:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants