-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry Viewer envfile configmap #153
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Codecov ReportBase: 43.92% // Head: 43.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 43.92% 43.92%
=======================================
Files 6 6
Lines 1020 1020
=======================================
Hits 448 448
Misses 530 530
Partials 42 42 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1fe4ed2
to
7026e96
Compare
…lias field in configmap object .env.registry-viewer Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
76eb31b
to
da7dbee
Compare
Need to apply fixes to Dockerfiles for non root support in minikube |
aadda67
to
da7dbee
Compare
blocked by #154 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
What does does this PR do / why we need it:
Replaces environment variable definitions for the registry viewer with environment variable file content in the
configmap.yaml
for the helm chart, this is a requirement for the registry viewer analytics write key to be set.Additional Changes
Sets the required security context for the registry viewer container, currently needed for OpenShift 4.12 deployments.
Which issue(s) this PR fixes:
Fixes #?
part of devfile/api#747
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: