-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update license header file to use the year 2023 #155
Conversation
1b13f41
to
bd6bc40
Compare
Codecov ReportBase: 43.92% // Head: 43.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 43.92% 43.20% -0.73%
==========================================
Files 6 6
Lines 1020 1037 +17
==========================================
Hits 448 448
- Misses 530 546 +16
- Partials 42 43 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-valdron thanks for looking at this so quickly. I should have clarified in my issue that the requested changes are for the https://github.com/devfile/registry-support/blob/main/license_header.txt. This ensures the header gets added to new files for the current year.
The rules for updating existing files are:
- If there are no changes, then no need to update
- If file has changes, then we need to update in the format
[original year]-[year in which the file was updated]
I'll update the issue with these details
bd6bc40
to
15f2565
Compare
15f2565
to
671e054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this should be just the year 2023
since it only gets applied to new files
671e054
to
d94ae58
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
d94ae58
to
9696064
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Valdron mvaldron@redhat.com
Please specify the area for this PR
What does does this PR do / why we need it:
Updates license headers to 2023
Which issue(s) this PR fixes:
Fixes #?
devfile/api#1004
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: