Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable definitions for registry viewer deployment #160

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Feb 3, 2023

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR

registry

What does does this PR do / why we need it:

Provides required fixes to setting environment variables on the registry viewer deployment within the helm chart template.

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#1016

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

…er in helm chart deployment template.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval by writing /assign @maysunfaisal in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 785a498 into devfile:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants