Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index/generator): adding command groups to index schema #163

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

mike-hoang
Copy link
Contributor

Signed-off-by: Michael Hoang mhoang@redhat.com

Please specify the area for this PR
index/generator

What does does this PR do / why we need it:
Adds the command groups defined in the devfile stack to the registry index.

After this PR is merged, the index server needs to be:

  • updated with the index/generator version that contains the schema change
  • updated with the new index response in the docs

Which issue(s) this PR fixes:

Fixes devfile/api#996

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

  • build the image with the changes using build_registry
  • deploy image to a cluster and check the /v2index endpoint

Screenshot 2023-02-13 at 8 05 04 PM

Screenshot 2023-02-13 at 8 07 36 PM

Signed-off-by: Michael Hoang <mhoang@redhat.com>
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 43.20% // Head: 43.20% // No change to project coverage 👍

Coverage data is based on head (bb637ed) compared to base (5c01f60).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files           6        6           
  Lines        1037     1037           
=======================================
  Hits          448      448           
  Misses        546      546           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, mike-hoang
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants