Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry fix for helm deployment #164

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

michael-valdron
Copy link
Member

Please specify the area for this PR

What does does this PR do / why we need it:

Corrects the environment variable name for the analytics write key, ANALYTICS_WRITE_KEY to NEXT_PUBLIC_ANALYTICS_WRITE_KEY. This change should fix the broken telemetry.

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#1006

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 43.20% // Head: 43.20% // No change to project coverage 👍

Coverage data is based on head (3723a71) compared to base (4eaedcc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files           6        6           
  Lines        1037     1037           
=======================================
  Hits          448      448           
  Misses        546      546           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign elsony for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 3b53719 into devfile:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants