-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iconUrl check upon index component validation #167
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 43.20% 43.20%
=======================================
Files 6 6
Lines 1037 1037
=======================================
Hits 448 448
Misses 546 546
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
c471793
to
36ab842
Compare
ed6b92a
to
9c9c61e
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Co-authored-by: Michael Valdron <michael.valdron@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com>
This reverts commit e2c1383. Signed-off-by: thepetk <thepetk@gmail.com>
This reverts commit ae9393d. Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
9c9c61e
to
182a8df
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, thepetk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: thepetk <thepetk@gmail.com>
New changes are detected. LGTM label has been removed. |
Please specify the area for this PR
registry/
What does does this PR do / why we need it:
Adds an
iconUrl
check inside thegenerator.library.validateIndexComponent
func.This way it blocks the build of the registry if an icon does not exist, or has an invalid url.
Which issue(s) this PR fixes:
devfile/api#1024
Fixes #?
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
.ci/Dockerfile
git clone command in order to clone the branch of my fork instead of the registry support repo. This way you will be able to test my build tools.