-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry probing to integration test suite #170
Add registry probing to integration test suite #170
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 42.69% 42.69%
=======================================
Files 6 6
Lines 1047 1047
=======================================
Hits 447 447
Misses 557 557
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
integration tests
What does does this PR do / why we need it:
Add the optional ability to enforce a successful health check probe on the target registry in order to run tests. This feature is required to fix staging deployment problems due to the acceptance testing running before the deployment is ready.
Additional Changes
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1086
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
PROBE_TIMEOUT
environment variable setdocker run --rm --env REGISTRY=$REGISTRY --env PROBE_TIMEOUT=60 devfile-registry-integration