-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix manifest #171
fix manifest #171
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 42.69% 42.28% -0.41%
==========================================
Files 6 6
Lines 1047 1057 +10
==========================================
Hits 447 447
- Misses 557 567 +10
Partials 43 43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
It looks like I need to have the staging server updated in order to add more unit tests. It doesn't make sense to mock when I need a real OCI server to work with. I'll add my manual testing to the PR description and open up a new issue to add new tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
What does does this PR do / why we need it:
Add an additional v2.2.0 schema stack with a deploy.yaml on the test registry so local testing can be doneWhich issue(s) this PR fixes:
Fixes #?
devfile/api#1089
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Rebuilt the index server and deployed on a local cluster. Tested with the following testcase and confirmed the
devfile.yaml
andkubernetes/deploy.yaml
were downloadedAlso verified this works with
odo