Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for PullStackFromRegistry and PullStackByMediaTypes… #172

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Apr 6, 2023

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Adds additional coverage to our registry library to test the downloading of stack resources

Which issue(s) this PR fixes:
Fixes #?
devfile/api#1094

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

…FromRegistry

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

@kim-tsao: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

…FromRegistry

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Adds additional coverage to our registry library to test the downloading of stack resources

Which issue(s) this PR fixes:
Fixes #?
devfile/api#1094

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kim-tsao kim-tsao marked this pull request as ready for review April 6, 2023 22:18
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ff8153b) 42.28% compared to head (206b650) 42.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   42.28%   42.28%           
=======================================
  Files           6        6           
  Lines        1057     1057           
=======================================
  Hits          447      447           
  Misses        567      567           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 11a8482 into devfile:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants