Update directly executed scripts on workflows and scripts

[thepetk]

Please specify the area for this PR

/area ci

What does does this PR do / why we need it:

It ensures that all script executions, inside .github/workflows and inside scripts code, are not directly executed and that the script file is passed to the appropriate shell defined by the scripts shebang. For example. in the case of a bash script ./build.sh would become bash ./build.sh.

Which issue(s) this PR fixes:

fixes devfile/api#973

Fixes #?

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

[openshift-ci]

@thepetk: The label(s) area/ci cannot be applied, because the repository doesn't have them.

In response to this:

Please specify the area for this PR

/area ci

What does does this PR do / why we need it:

It ensures that all script executions, inside .github/workflows and inside scripts code, are not directly executed and that the script file is passed to the appropriate shell defined by the scripts shebang. For example. in the case of a bash script ./build.sh would become bash ./build.sh.

Which issue(s) this PR fixes:

fixes devfile/api#973

Fixes #?

PR acceptance criteria:

• Test Coverage
  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (11a8482) 42.28% compared to head (a4feb9f) 42.28%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   42.28%   42.28%           
=======================================
  Files           6        6           
  Lines        1057     1057           
=======================================
  Hits          447      447           
  Misses        567      567           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[michael-valdron]

The following lines are missing bash:

• https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/.ci/run_tests_minikube_linux.sh#L15
• https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/.ci/run_tests_minikube_linux.sh#L43
• https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/.ci/Dockerfile#L34

Also, either:

• Add RUN chmod +x /entrypoint.sh after https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/index/server/Dockerfile#L13
  or
• Add bash to https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/index/server/Dockerfile#L41

[michael-valdron]

Also, either:

• Add RUN chmod +x /entrypoint.sh after https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/index/server/Dockerfile#L13
  or
• Add bash to https://github.com/thepetk/devfile-registry-support/blob/21b3c798866953932547c0b60a035e26dde6f325/index/server/Dockerfile#L41

My mistake, test is failing because of my last suggestion. Revert this and do the first one.

Could you add RUN chmod +x /entrypoint.sh after https://github.com/thepetk/devfile-registry-support/blob/2ba2ba41bad7daf4065b0e17418a88119f803a05/index/server/Dockerfile#L13. Still need this because of the assumption that the source entrypoint.sh will be non-executable.

[michael-valdron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michael-valdron, thepetk
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment