Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema version validation changes #174

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jun 14, 2023

Please specify the area for this PR

index server

What does does this PR do / why we need it:

Changes contain the following:

  • schema version validation error response code changed from 500 internal server to 400 bad request
  • optional bugfix version allowed, e.g. both 2.2 and 2.2.0 are accepted schema versions

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1128

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

* schema version validation error response code changed from 500 to 400
* optional bugfix version allowed

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +3.40 🎉

Comparison is base (200b4f0) 42.28% compared to head (980b084) 45.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   42.28%   45.69%   +3.40%     
==========================================
  Files           6        6              
  Lines        1057     1057              
==========================================
+ Hits          447      483      +36     
+ Misses        567      533      -34     
+ Partials       43       41       -2     
Impacted Files Coverage Δ
index/server/pkg/server/endpoint.go 42.85% <100.00%> (+7.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…must be 2.x or higher.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…maxSchemaVersion.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review June 15, 2023 20:42
@michael-valdron michael-valdron changed the title [WIP]Schema version validation changes Schema version validation changes Jun 15, 2023
@michael-valdron
Copy link
Member Author

Testing against staging failing due to these changes to be tested not being merged and deployed to staging yet.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit bdfb830 into devfile:main Jun 20, 2023
7 of 8 checks passed
@michael-valdron michael-valdron deleted the bugfix/schemaversion branch June 29, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants