-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scripts to build and package starter projects for offline registries #179
Conversation
@mike-hoang: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 35.93% 35.93%
=======================================
Files 7 7
Lines 1347 1347
=======================================
Hits 484 484
Misses 816 816
Partials 47 47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Especially the update_devfiles_offline.sh
💯 I've left some minor comments. I'll try to build and test it more thoroughly!
Signed-off-by: Michael Hoang <mhoang@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build the registry image locally and test it with minikube. More detailed I can see that for the offline build we are adding:
starterProjects:
- name: go-starter
zip:
location: go-starter-offline.zip
Also I've checked inside the image and we are including the necessary zip
file with the starterproject.
As we have discussed offline, a next step should be to update https://devfile.io/docs/2.2.0/installation-of-in-cluster-offline-devfile-registry
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mike-hoang, thepetk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ies (devfile#179) Signed-off-by: Michael Hoang <mhoang@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
/area registry
What does does this PR do / why we need it:
Updates
dl_starter_projects.sh
Adds
update_devfiles_offline.sh
Which issue(s) this PR fixes:
Fixes devfile/api#1203
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
To test locally:
STACK_DIR
toSTACKS_DIR=tests/registry/stacks
bash /registry-support/build-tools/dl_starter_projects.sh
,bash /registry-support/build-tools/update_devfiles_offline.sh
To test with the registry build script:
bash build.sh offline
Verify that resources are inside the stack:
docker run --rm -it --entrypoint bash devfile-index
cd /registry/stacks/