-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and update license headers #186
Add and update license headers #186
Conversation
b156eeb
to
94a6bc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 35.93% 35.93%
=======================================
Files 7 7
Lines 1347 1347
=======================================
Hits 484 484
Misses 816 816
Partials 47 47
☔ View full report in Codecov by Sentry. |
cf2fcce
to
135d00e
Compare
fixed in 135d00e |
11b82f0
to
f390f16
Compare
Testing is blocked: devfile/api#1294 (comment) |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-valdron I think we need to rebase to the latest main to fix the check which fails atm
Yeah forgot to rebase the fix in, rebasing now.. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
f390f16
to
ecf88ff
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Please specify the area for this PR
What does does this PR do / why we need it:
Adds and updates license headers in all source files, script files, and configuration files. License header changes were completed in devfile/api#1242.
Additional changes: Adds logging of diffs when generation of source is different than generated source changes in commits.
Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1294
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
For
oapi-codegen
use the following to install:go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@v1.12.4