Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update license headers #186

Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Oct 18, 2023

Please specify the area for this PR

What does does this PR do / why we need it:

Adds and updates license headers in all source files, script files, and configuration files. License header changes were completed in devfile/api#1242.

Additional changes: Adds logging of diffs when generation of source is different than generated source changes in commits.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1294

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

For oapi-codegen use the following to install: go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@v1.12.4

@openshift-ci openshift-ci bot requested review from rm3l and thepetk October 18, 2023 15:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@michael-valdron michael-valdron force-pushed the bugfix/add-license-headers branch 2 times, most recently from b156eeb to 94a6bc4 Compare October 18, 2023 16:02
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (086246b) 35.93% compared to head (ecf88ff) 35.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   35.93%   35.93%           
=======================================
  Files           7        7           
  Lines        1347     1347           
=======================================
  Hits          484      484           
  Misses        816      816           
  Partials       47       47           
Files Coverage Δ
index/server/pkg/server/endpoint.gen.go 2.69% <ø> (ø)
index/server/pkg/server/endpoint.go 40.90% <ø> (ø)
index/server/pkg/server/index.go 0.00% <ø> (ø)
index/server/pkg/server/registry.go 21.27% <ø> (ø)
index/server/pkg/util/filter.go 86.66% <ø> (ø)
index/server/pkg/util/telemetry.go 72.60% <ø> (ø)
index/server/pkg/util/util.go 65.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-valdron michael-valdron changed the title Add and update license headers WIP: Add and update license headers Oct 18, 2023
@michael-valdron michael-valdron force-pushed the bugfix/add-license-headers branch 4 times, most recently from cf2fcce to 135d00e Compare October 18, 2023 20:06
@michael-valdron
Copy link
Member Author

Additional changes: Adds logging of diffs when generation of source is different than generated source changes in commits.

fixed in 135d00e

@michael-valdron michael-valdron changed the title WIP: Add and update license headers Add and update license headers Oct 18, 2023
@michael-valdron
Copy link
Member Author

Testing is blocked: devfile/api#1294 (comment)

@thepetk
Copy link
Contributor

thepetk commented Oct 19, 2023

/retest

1 similar comment
@michael-valdron
Copy link
Member Author

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-valdron I think we need to rebase to the latest main to fix the check which fails atm

@michael-valdron
Copy link
Member Author

@michael-valdron I think we need to rebase to the latest main to fix the check which fails atm

Yeah forgot to rebase the fix in, rebasing now..

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk
Copy link
Contributor

thepetk commented Oct 20, 2023

/lgtm

@michael-valdron michael-valdron merged commit 1168591 into devfile:main Oct 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants